[PATCH] D88785: Support {S,U}REMEqFold before legalization

Wed Mar 31 13:49:41 PDT 2021

craig.topper added inline comments.

================
Comment at: llvm/test/CodeGen/RISCV/rvv/vmulh-sdnode-rv32.ll:16
+; CHECK-NEXT:    vmv.v.i v26, 1
+; CHECK-NEXT:    vrsub.vi v27, v26, 0
+; CHECK-NEXT:    vand.vi v27, v27, 7
----------------
craig.topper wrote:
> nagisa wrote:
> > craig.topper wrote:
> > > Something silly happened here. The vrsub.vi+vmv.vi appears to be calculating -1 without constant folding. Probably DAG combine not constant folding scalable vectors?
> > Should I look into this? Seems somewhat out of scope for this diff. Should I file an issue instead?
> File an issue and assign it to me.
I think https://reviews.llvm.org/D99682 will fix this.

================
Comment at: llvm/test/CodeGen/RISCV/urem-seteq-illegal-types.ll:577
 ; RV32MV-NEXT:    vle16.v v26, (a1)
+; RV32MV-NEXT:    vid.v v27
+; RV32MV-NEXT:    vsub.vv v25, v25, v27
----------------
I think this test needs to be regenerated. Some of the vset(i)vli instructions should be optimized out.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88785/new/

https://reviews.llvm.org/D88785