[PATCH] D99575: [ARM] Clarify a comment regarding AArch64. NFC.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 31 13:38:50 PDT 2021
mstorsjo updated this revision to Diff 334522.
mstorsjo added a comment.
Updated to remove the parameter and the related asserts.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99575/new/
https://reviews.llvm.org/D99575
Files:
llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendWinCOFF.h
llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.h
llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
Index: llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
@@ -27,9 +27,8 @@
class ARMWinCOFFObjectWriter : public MCWinCOFFObjectTargetWriter {
public:
- ARMWinCOFFObjectWriter(bool Is64Bit)
+ ARMWinCOFFObjectWriter()
: MCWinCOFFObjectTargetWriter(COFF::IMAGE_FILE_MACHINE_ARMNT) {
- assert(!Is64Bit && "AArch64 support not yet implemented");
}
~ARMWinCOFFObjectWriter() override = default;
@@ -48,9 +47,6 @@
const MCFixup &Fixup,
bool IsCrossSection,
const MCAsmBackend &MAB) const {
- assert(getMachine() == COFF::IMAGE_FILE_MACHINE_ARMNT &&
- "AArch64 support not yet implemented");
-
MCSymbolRefExpr::VariantKind Modifier =
Target.isAbsolute() ? MCSymbolRefExpr::VK_None : Target.getSymA()->getKind();
@@ -104,8 +100,8 @@
namespace llvm {
std::unique_ptr<MCObjectTargetWriter>
-createARMWinCOFFObjectWriter(bool Is64Bit) {
- return std::make_unique<ARMWinCOFFObjectWriter>(Is64Bit);
+createARMWinCOFFObjectWriter() {
+ return std::make_unique<ARMWinCOFFObjectWriter>();
}
} // end namespace llvm
Index: llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.h
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.h
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.h
@@ -106,7 +106,7 @@
/// Construct an ARM PE/COFF object writer.
std::unique_ptr<MCObjectTargetWriter>
-createARMWinCOFFObjectWriter(bool Is64Bit);
+createARMWinCOFFObjectWriter();
/// Construct ARM Mach-O relocation info.
MCRelocationInfo *createARMMachORelocationInfo(MCContext &Ctx);
Index: llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendWinCOFF.h
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendWinCOFF.h
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackendWinCOFF.h
@@ -20,7 +20,7 @@
: ARMAsmBackend(T, STI, support::little) {}
std::unique_ptr<MCObjectTargetWriter>
createObjectTargetWriter() const override {
- return createARMWinCOFFObjectWriter(/*Is64Bit=*/false);
+ return createARMWinCOFFObjectWriter();
}
};
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99575.334522.patch
Type: text/x-patch
Size: 2452 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210331/2e2bec78/attachment.bin>
More information about the llvm-commits
mailing list