[PATCH] D88785: Support {S,U}REMEqFold before legalization

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 12:46:31 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/vmulh-sdnode-rv32.ll:16
+; CHECK-NEXT:    vmv.v.i v26, 1
+; CHECK-NEXT:    vrsub.vi v27, v26, 0
+; CHECK-NEXT:    vand.vi v27, v27, 7
----------------
nagisa wrote:
> craig.topper wrote:
> > Something silly happened here. The vrsub.vi+vmv.vi appears to be calculating -1 without constant folding. Probably DAG combine not constant folding scalable vectors?
> Should I look into this? Seems somewhat out of scope for this diff. Should I file an issue instead?
File an issue and assign it to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88785/new/

https://reviews.llvm.org/D88785



More information about the llvm-commits mailing list