[PATCH] D99279: [lld-macho] Parallelize UUID hash computation
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 31 12:39:42 PDT 2021
int3 marked an inline comment as done.
int3 added inline comments.
================
Comment at: lld/MachO/Writer.cpp:929
+ ArrayRef<uint8_t> data{buffer->getBufferStart(), buffer->getBufferEnd()};
+ unsigned chunkCount = parallel::strategy.compute_thread_count() * 10;
+ // Round-up integer division
----------------
oontvoo wrote:
> It seems `strategy` is only initted to hardware_concurrency (in Driver.cpp) if `--threads` is set.
> Do we care to set set it unconditionally?
>
The default-constructed `strategy` will return the right value for `compute_thread_count()` too, so we don't need to
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99279/new/
https://reviews.llvm.org/D99279
More information about the llvm-commits
mailing list