[PATCH] D98508: Restore lit feature object-emission

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 10:53:34 PDT 2021


MaskRay added a comment.

There are other targets which don't support/use integrated assembler but they are not host targets, so that is fine.
Now you want to run XCore as something similar like a host target and exercise these tests, I think it is reasonable to add more requirement like supporting integrated assembler.
Otherwise new tests may be developed with subsequent fixups that add `REQUIRES: object-emission`. That is certainly a maintenance burden.

This is a phase ordering issue. If an integrated assembler is planned, adding `REQUIRES: object-emission` and then removing `REQUIRES: object-emission` is just churn.
If there are few tests in some directory which needs `REQUIRES: object-emission`, I think adding the annotation is fine if that conveniences you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98508/new/

https://reviews.llvm.org/D98508



More information about the llvm-commits mailing list