[PATCH] D94856: [X86] Improve optimizeCompareInstr for signed comparisons after BMI/TBM instructions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 09:24:30 PDT 2021


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM cheers



================
Comment at: llvm/test/CodeGen/X86/bmi.ll:542
 
 define i32 @blsi32_sle(i32 %a, i32 %b, i32 %c) nounwind {
 ; X86-LABEL: blsi32_sle:
----------------
craig.topper wrote:
> This should be equivalent to the PR48768, but with cmovcc instead of setcc.
SGTM - please can you just add a comment mentioning PR48768 ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94856/new/

https://reviews.llvm.org/D94856



More information about the llvm-commits mailing list