[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/test/CodeGen/X86/bug26810.ll:1
-; RUN: llc < %s -march=x86 -regalloc=greedy -stop-after=greedy | FileCheck %s
+; RUN: llc -consider-local-interval-cost < %s -march=x86 -regalloc=greedy -stop-after=greedy | FileCheck %s
 ; Make sure bad eviction sequence doesnt occur
----------------
dmgreen wrote:
> If we are enabling this flag by default, we should probably update the tests, not hide them behind a flag.
We're not enabling it by default though, that'd regress compile time.


================
Comment at: llvm/test/CodeGen/X86/i128-mul.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
-; RUN: llc < %s -mtriple=i686-unknown-unknown | FileCheck %s --check-prefix=X86-NOBMI
+; RUN: llc -consider-local-interval-cost < %s -mtriple=i686-unknown-unknown | FileCheck %s --check-prefix=X86-NOBMI
 ; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+bmi2 | FileCheck %s --check-prefix=X86-BMI
----------------
nikic wrote:
> Don't think regalloc details are important for this test and the two below. Might want to regenerate the output rather than adding the flag for these. (The two tests above specifically test for regalloc behavior.)
sgtm, I'll do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98232/new/

https://reviews.llvm.org/D98232