[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D98232#2661457 <https://reviews.llvm.org/D98232#2661457>, @dmgreen wrote:

>> Quick update on the code quality side, I ran spec2006, the llvm benchmarks, the eigen benchmarks, and a few others, on x86 (FDO, thinlto) with this patch, and with/without enabling consider-local-interval-cost. No significant real effect.
>
> I would expect any large out of order cpu to chew through register mov's like they aren't even there. They just end up as register renames. It will be in-order "little" cores where this hurts the most.

Right, unfortunately I don't have access to those.

> Can you remove -consider-local-interval-cost from the tests?

It's disabled by default (I'm assuming it's about your comment on bug26810.ll - I'll reply there)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98232/new/

https://reviews.llvm.org/D98232