[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 31 07:34:01 PDT 2021
dmgreen added a comment.
> Quick update on the code quality side, I ran spec2006, the llvm benchmarks, the eigen benchmarks, and a few others, on x86 (FDO, thinlto) with this patch, and with/without enabling consider-local-interval-cost. No significant real effect.
I would expect any large out of order cpu to chew through register mov's like they aren't even there. They just end up as register renames. It will be in-order "little" cores where this hurts the most.
Can you remove -consider-local-interval-cost from the tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98232/new/
https://reviews.llvm.org/D98232
More information about the llvm-commits
mailing list