[PATCH] D97470: [CostModel] Align the cost model for intrinsics for scalable/fixed-width vectors.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 07:02:51 PDT 2021


sdesmalen added a comment.

Thanks for the review comments!



================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:1346
     unsigned ScalarizationCost = std::numeric_limits<unsigned>::max();
-    if (RetVF.isVector()) {
+    if (RetVF.isVector() && !RetVF.isScalable()) {
       ScalarizationCost = 0;
----------------
david-arm wrote:
> nit: Could you just use `RetVF.isFixedLengthVector()` instead here?
That's a method of EVT, not ElementCount unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97470/new/

https://reviews.llvm.org/D97470



More information about the llvm-commits mailing list