[PATCH] D99649: [ARM] Updates to arm-block-placement pass

Malhar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 06:35:53 PDT 2021


malharJ added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:180
+    if (CanMove) {
+      // doesnt have to be Preheader, refers to any BB that contains
+      // t2WhileLoopStartLR
----------------
dmgreen wrote:
> doesnt -> Doesn't
> 
> I'm not sure what this comment is adding. It's probably better to just rename Preheader to Predecessor, if the name is wrong.
Had left the comment by accident. I agree and I've renamed the variable now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99649/new/

https://reviews.llvm.org/D99649



More information about the llvm-commits mailing list