[llvm] d2d6720 - [InlineCost] Remove TODO comment that consider other forms of savings in the cost-benefit analysis

[Liqiang Tao via llvm-commits]

Author: Liqiang Tao
Date: 2021-03-31T20:11:32+08:00
New Revision: d2d6720a93a2469fb3a752bd59674bd2cf97d91f

URL: https://github.com/llvm/llvm-project/commit/d2d6720a93a2469fb3a752bd59674bd2cf97d91f
DIFF: https://github.com/llvm/llvm-project/commit/d2d6720a93a2469fb3a752bd59674bd2cf97d91f.diff

LOG: [InlineCost] Remove TODO comment that consider other forms of savings in the cost-benefit analysis

Attempts to compute savings more accurately cannot impact the set of critically important call sites.

Reviewed By: kazu

Differential Revision: https://reviews.llvm.org/D98577

Added: 
    

Modified: 
    llvm/lib/Analysis/InlineCost.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp
index 06e4d9bf5995..06cc778ade74 100644
--- a/llvm/lib/Analysis/InlineCost.cpp
+++ b/llvm/lib/Analysis/InlineCost.cpp
@@ -761,9 +761,6 @@ class InlineCostCallAnalyzer final : public CallAnalyzer {
             CurrentSavings += InlineConstants::InstrCost;
           }
         }
-        // TODO: Consider other forms of savings like switch statements,
-        // indirect calls becoming direct, SROACostSavings, LoadEliminationCost,
-        // etc.
       }
 
       auto ProfileCount = CalleeBFI->getBlockProfileCount(&BB);