[PATCH] D99649: [ARM] Updates to arm-block-placement pass

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:72
+/// in its only predecessor
+static MachineBasicBlock *findWLS(MachineLoop *ML) {
+  MachineBasicBlock *Preheader = ML->getLoopPredecessor();
----------------
Consider renaming this helper, it currently reads like it would be returning a WLS instruction.


================
Comment at: llvm/lib/Target/ARM/ARMBlockPlacement.cpp:89
+/// predecessor).
+void ARMBlockPlacement::fixWLS(MachineLoop *ML, bool &Changed) {
+  MachineBasicBlock *Preheader = findWLS(ML);
----------------
return bool instead of using 'Changed'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99649/new/

https://reviews.llvm.org/D99649