[PATCH] D99475: [OCaml] Omit unnecessary GC root registrations

Josh Berdine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 04:25:38 PDT 2021


jberdine added a comment.

I have been testing this stack of diffs with a sort of stress test that involves running a system that consumes bitcode and uses the ocaml api to traverse and translate it. The testing has used a range of OCaml GC settings in order to make the GC work much harder and trigger much more often than usual (e.g. `Gc.set {(Gc.get ()) with minor_heap_size= 1024; space_overhead= 20}`). The reasoning here is that if the bindings are not playing nice with the GC, then there is a higher chance to uncover such issues if the GC runs much more often. This testing has not revealed any issues.

@vaivaswatha if it is not too much overhead in your application, it would be helpful if you could `arc patch` these diffs, add a call to `Gc.set` as above in your initialization code, and just run your application to see if there are any crashes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99475/new/

https://reviews.llvm.org/D99475



More information about the llvm-commits mailing list