[PATCH] D88785: Support {S,U}REMEqFold before legalization

Wed Mar 31 04:16:01 PDT 2021

RKSimon added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5631

   if (isOperationLegalOrCustom(ISD::VSELECT, SETCCVT)) {
     // If we have a vector select, let's replace the comparison results in the
----------------
nagisa wrote:
> lebedev.ri wrote:
> > What about this one?
> Letting these through has resulted in some very mixed results, as seen [in this comparison between older versions of this differential](https://reviews.llvm.org/D88785?vs=295993&id=296002#toc).
> 
> I have decided to back these out to improve chances of this differential landing without major hurdles. I may consider looking into these operations again in a followup differential.
Please can you add TODO/NOTE comments to each case explaining this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88785/new/

https://reviews.llvm.org/D88785