[PATCH] D97624: [X86] Improve SMULO/UMULO codegen for vXi8 vectors.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 04:14:31 PDT 2021


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM, I still think in the long run we should be trying to make this ISD::SMUL_LOHI/UMUL_LOHI, but if the legalizers aren't up to the job yet this is a good first step.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30199
   case ISD::USUBO:
+    return LowerXALUO(Op, DAG);
   case ISD::SMULO:
----------------
Use the same indentation as the rest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97624/new/

https://reviews.llvm.org/D97624



More information about the llvm-commits mailing list