[PATCH] D99644: [WebAssembly] Raname a test and fix comments
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 31 02:34:26 PDT 2021
aheejin created this revision.
aheejin added a reviewer: dschuff.
Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100.
aheejin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
D99627 <https://reviews.llvm.org/D99627> fixed a decoding bug, not an encoding bug. This renames the test
to correct it and fix comments.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D99644
Files:
llvm/test/MC/WebAssembly/event-section-decoding.ll
llvm/test/MC/WebAssembly/event-section-encoding.ll
Index: llvm/test/MC/WebAssembly/event-section-decoding.ll
===================================================================
--- llvm/test/MC/WebAssembly/event-section-decoding.ll
+++ llvm/test/MC/WebAssembly/event-section-decoding.ll
@@ -1,6 +1,6 @@
; RUN: llc -filetype=obj -exception-model=wasm -mattr=+exception-handling %s -o - | obj2yaml | FileCheck %s
-; This is a regression test for an encoding bug that happens when an event's
+; This is a regression test for a decoding bug that happens when an event's
; sigindex is greater than 63, so we put 63 dummy functions with different
; signatures before the function that contains the 'throw' instruction to make
; the event's sigindex 64.
@@ -334,8 +334,8 @@
ret i32 0
}
-; Checks to see if the event index is correctly encoded in ULEB128. If it is
-; encoded with LEB128, 64 will not be correctly decoded. 64 is the smallest
+; Checks to see if the event index is correctly decoded in ULEB128. If it is
+; decoded with LEB128, 64 will not be correctly decoded. 64 is the smallest
; number with which its LEB128 and ULEB128 encodings are different, because its
; 7th least significant bit is not 0.
; CHECK: - Type: EVENT
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99644.334387.patch
Type: text/x-patch
Size: 1210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210331/35831487/attachment.bin>
More information about the llvm-commits
mailing list