[PATCH] D99171: [WebAssembly] Fold xor by inverting branch target

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 00:54:47 PDT 2021


samparker added a comment.

> Can you add tests that do explicit xors in the IR to show that it is not folded out where it shouldn't be?

Well this is what I mean, that I don't think this is possible. Writing a test in IR, the br has to take an i1, though this is expanded to i32 during codegen. I could write some IR tests with xors, but they should all be valid. AFAIK, I'd need a way of writing a test input in selection dag form to write a negative test. I have missed some FP conditions in the existing tests, so I'm going to add those.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99171/new/

https://reviews.llvm.org/D99171



More information about the llvm-commits mailing list