[PATCH] D99552: [openmp][ELF] Recognize LLVM OpenMP offload specific notes

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Couple of nits, otherwise looks good to me.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-llvmompoffload.test:1
+# Test that llvm-readobj is able to recognize LLVMOMPOFFLOAD ELF notes.
+
----------------
Nit: In more recent llvm tool tests, we tend to use '##' for comment markers, to distinguish them from lit and FileCheck directives.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-llvmompoffload.test:4
+# RUN: yaml2obj %s -o %t.64le -DBITS=64 -DENCODING=LSB
+# RUN: llvm-readobj --notes %t.64le | FileCheck %s --check-prefix=NOTES
+# RUN: llvm-readelf --notes %t.64le | FileCheck %s --check-prefix=NOTES-GNU
----------------
Here and in each other case, I'd add `--match-full-lines` to the FileCheck call, as this will prevent other output in the Type etc fields after the checked-for value.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-llvmompoffload.test:19-20
+# NOTES-NEXT:     Name: .note.openmp
+# NOTES-NEXT:     Offset:
+# NOTES-NEXT:     Size:
+# NOTES-NEXT:     Note {
----------------
If you go ahead with my `--match-full-lines` suggestion, use `{{.*}}` as a regex to avoid having to check the actual offset and size here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99552/new/

https://reviews.llvm.org/D99552