[PATCH] D99634: [llvm-reduce] Add header guards and fix clang-tidy warnings

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 21:57:23 PDT 2021


aeubanks added a comment.

mostly looks good, one suggestion



================
Comment at: llvm/tools/llvm-reduce/DeltaManager.h:36
 // TODO: Add CLI option to run only specified Passes (for unit tests)
 inline void runDeltaPasses(TestRunner &Tester) {
   reduceSpecialGlobalsDeltaPass(Tester);
----------------
this definition should probably be moved into a .cpp file. And it shouldn't be `inline`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99634/new/

https://reviews.llvm.org/D99634



More information about the llvm-commits mailing list