[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:28
+TARGET_BUILTIN(__builtin_riscv_crc32_d, "LiLi", "nc", "experimental-zbr")
+TARGET_BUILTIN(__builtin_riscv_crc32c_d, "LiLi", "nc", "experimental-zbr")
+
----------------
Jim wrote:
> I don't know why it doesn't use __rv__* prefix directly?
I believe using __builtin* is consistent with how intrinsics are handled on most targets in both clang and gcc. We wouldn't want the __rv symbols declared unless the user has included rvintrin.h. There is some support for detecting that, see HEADER_BUILTIN in Builtins.def, but it's used rarely for target specific intrinsics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99009/new/

https://reviews.llvm.org/D99009