[llvm] 0d7fd9f - [GlobalISel] Fix Wint-in-bool-context warning (NFC)
Yang Fan via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 30 19:00:18 PDT 2021
Author: Yang Fan
Date: 2021-03-31T09:59:43+08:00
New Revision: 0d7fd9f0d09812c6344a7df6498ce504c8d646d1
URL: https://github.com/llvm/llvm-project/commit/0d7fd9f0d09812c6344a7df6498ce504c8d646d1
DIFF: https://github.com/llvm/llvm-project/commit/0d7fd9f0d09812c6344a7df6498ce504c8d646d1.diff
LOG: [GlobalISel] Fix Wint-in-bool-context warning (NFC)
GCC warning:
```
/llvm-project/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp: In member function ‘bool llvm::CombinerHelper::matchFunnelShiftToRotate(llvm::MachineInstr&)’:
/llvm-project/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3882:35: warning: ?: using integer constants in boolean context, the expression will always evaluate to ‘true’ [-Wint-in-bool-context]
3882 | Opc == TargetOpcode::G_FSHL ? TargetOpcode::G_ROTL : TargetOpcode::G_ROTR;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Added:
Modified:
llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
index 115010ae6304..7795b5088e6f 100644
--- a/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
@@ -3878,7 +3878,7 @@ bool CombinerHelper::matchFunnelShiftToRotate(MachineInstr &MI) {
Register Y = MI.getOperand(2).getReg();
if (X != Y)
return false;
- bool RotateOpc =
+ unsigned RotateOpc =
Opc == TargetOpcode::G_FSHL ? TargetOpcode::G_ROTL : TargetOpcode::G_ROTR;
return isLegalOrBeforeLegalizer({RotateOpc, {MRI.getType(X), MRI.getType(Y)}});
}
More information about the llvm-commits
mailing list