[PATCH] D93411: [GlobalISel] Transform sext (cmp pred, x, y) -> select (cmp pred, x, y) tval, 0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3152
+  if (ExtTy.isVector() ||
+      getTargetLowering().convertSelectOfConstantsToMath(ExtTy))
+    return false;
----------------
paquette wrote:
> arsenm wrote:
> > This doesn't check the inputs are constants? The name seems wrong
> The goal here is to avoid //creating// a select of constants from an extend if it will be transformed back into an extend later. So, there's no reason to check for constants here.
The DAG here skips this if the compare result type isn't i1, which is probably still a good idea


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93411/new/

https://reviews.llvm.org/D93411