[PATCH] D97007: [lld-macho] Define __mh_*_header synthetic symbols.

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 17:02:13 PDT 2021


smeenai added a comment.

In D97007#2636289 <https://reviews.llvm.org/D97007#2636289>, @int3 wrote:

> 2. We could make MachHeaderSection inherit from an InputSection rather than a OutputSection (SyntheticSection), and then have it be part of the `__TEXT` MergedOutputSection. This is more architecturally consistent, but would probably require a good deal of refactoring.

I don't have the full context here, but does this tie into the larger questions of whether SyntheticSections should be InputSections or OutputSections? https://bugs.llvm.org/show_bug.cgi?id=49780

To be clear, I'm not saying we're at the point where we should consider that refactoring yet; I'm just wondering if it's another data point that should be included when we eventually make that decision :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97007/new/

https://reviews.llvm.org/D97007



More information about the llvm-commits mailing list