[PATCH] D99560: Utility to construct visitors from lambdas.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/ADT/Visitor.h:35
+};
+
+template <class... LAMBDAS> auto makeVisitor(LAMBDAS... lambdas) {
----------------
Are the classes above part of the public API or could they be wrapped in a `detail` namespace?


================
Comment at: llvm/include/llvm/ADT/Visitor.h:36
+
+template <class... LAMBDAS> auto makeVisitor(LAMBDAS... lambdas) {
+  return Visitor<LAMBDAS...>(lambdas...);
----------------
Can you add some doc? And maybe include some code samples here if possible.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99560/new/

https://reviews.llvm.org/D99560