[PATCH] D99620: [CMake][Compiler-rt] Fix `LLVM_MAIN_SRC_DIR` to be correct when `llvm-config` reports a path that doesn't exist.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 16:20:17 PDT 2021


delcypher added a comment.

In D99620#2660017 <https://reviews.llvm.org/D99620#2660017>, @tstellar wrote:

> We still build compiler-rt in non-monorepo configuration for Fedora.  Which files from the llvm directory (or other directories in the monorepo) does compiler-rt depend on?

@tstellar Several. This subsequent patch (https://reviews.llvm.org/D99621) might illuminate some of this because it starts the work of trying to remove the dependency on the `LLVMConfig.cmake` file which is generated by an LLVM build but isn't necessarily shipped with toolchains.

In your case if the output of `llvm-config --src-root` is usable then the build should still work. You also have the option of invoking CMake with `-DLLVM_MAIN_SRC_DIR=/path/to/llvm` to set the path to be whatever you need it to be.

The intention though is to eventually deprecate calling `llvm-config --src-root` to get the LLVM source path but I am in no huge rush to do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99620/new/

https://reviews.llvm.org/D99620



More information about the llvm-commits mailing list