[PATCH] D99627: [WebAssembly] Encode numbers in ULEB128 in event section

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 16:11:03 PDT 2021


aheejin created this revision.
aheejin added a reviewer: dschuff.
Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100.
aheejin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The number of events and the type index should be encoded in ULEB128,
but they were incorrctly encoded in LEB128. The smallest number with
which its LEB128 and ULEB128 encodings are different is 64.
There's no way we can generate 64 events in the C++ toolchain
implementation so we can't test that, but the attached test tests when
the type index is 64.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99627

Files:
  llvm/lib/Object/WasmObjectFile.cpp
  llvm/test/MC/WebAssembly/event-section-encoding.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99627.334299.patch
Type: text/x-patch
Size: 15137 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210330/53b28aa9/attachment.bin>


More information about the llvm-commits mailing list