[PATCH] D99561: Support visitor pattern by PointerUnion.
Bakhtiyar Neyman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 30 15:57:46 PDT 2021
bakhtiyarneyman marked 3 inline comments as done.
bakhtiyarneyman added inline comments.
================
Comment at: llvm/unittests/ADT/PointerUnionTest.cpp:175
+ [&](double *doublePtr) { ptr = doublePtr; });
+ EXPECT_EQ(&d, ptr);
+}
----------------
ezhulenev wrote:
> I'd add a test case with labmdas returning values?
Discussed offline: unit test of Visitor in the diffbase tests this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99561/new/
https://reviews.llvm.org/D99561
More information about the llvm-commits
mailing list