[PATCH] D99284: [RegAllocFast] properly handle STATEPOINT instruction.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 15:19:35 PDT 2021


arsenm added a comment.

I don't think this should special case statepoints. Any regmask with tied operands should behave the same way



================
Comment at: llvm/test/CodeGen/X86/statepoint-fastregalloc.mir:3-7
+  ; ModuleID = 'test.ll'
+  source_filename = "test.ll"
+  target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+  target triple = "x86_64-pc-linux-gnu"
+  
----------------
Can remove this. Should also have a comment explaining the test


================
Comment at: llvm/test/CodeGen/X86/statepoint-fastregalloc.mir:25-66
+---
+name:            test_relocate
+alignment:       16
+exposesReturnsTwice: false
+legalized:       false
+regBankSelected: false
+selected:        false
----------------
Don't need most of this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99284/new/

https://reviews.llvm.org/D99284



More information about the llvm-commits mailing list