[PATCH] D99429: [AMDGPU] Save WWM registers in functions
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 30 15:17:13 PDT 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:1474
.addImm(0) // offset
- .addImm(0) // flags
+ .addImm(UseSP ? 1 : 0) // flags
.addMemOperand(MMO);
----------------
I think I missed adding an operand to the pseudos to tell it what frame register to use. Do we really need a flag for this? Why can't eliminateFrameIndex infer SP/FP/BP from the frame index?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99429/new/
https://reviews.llvm.org/D99429
More information about the llvm-commits
mailing list