[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda marked 3 inline comments as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFFObjectFile.h:35
+
+  mutable DenseMap<uint32_t, std::string> EsdNames;
+
----------------
jhenderson wrote:
> I'm trying to understand why `EsdNames` and `SectionData` are `mutable`. Are they intended as caches that are lazily populated? If so, I'd probably make that clear from the names (e.g. `EsdNamesCache` and `SectionDataCache`).
Yes, they are lazily filled and have been renamed.


================
Comment at: llvm/include/llvm/Object/GOFFObjectFile.h:97
+  bool isSectionData(DataRefImpl Sec) const override { return false; }
+  bool isSectionBSS(DataRefImpl Sec) const override { return false; }
+  bool isSectionVirtual(DataRefImpl Sec) const override { return false; }
----------------
kpn wrote:
> Wearing my MVS hat: What's BSS?
https://en.wikipedia.org/wiki/.bss. There is no equivalent in GOFF, therefore the return value false


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437