[PATCH] D99614: [flang] Update list-input test to use GTest

Asher Mancinelli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 11:38:23 PDT 2021


ashermancinelli added a comment.

If deemed reasonable, I'm happy to extend this to test more of the api as well - I'm open to suggestions. I'm also happy to keep this patch very short.



================
Comment at: flang/unittests/RuntimeGTest/ListInputTest.cpp:31
+  static constexpr int maxBufferLength{32};
+  static char buffer[numBuffers][maxBufferLength];
+  int j{0};
----------------
Buffer names `buffer` and `n` should be more descriptive IMO - @awarzynski do you have any suggestions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99614/new/

https://reviews.llvm.org/D99614



More information about the llvm-commits mailing list