[PATCH] D97897: [MSan][RISCV][Draft] Draft implementation of MSan RISC-V support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/test/msan/mmap.cpp:30
          (addr >= 0x440000000000ULL && addr < 0x500000000000);
+#elif defined(__riscv) && (__riscv_xlen == 64)
+  return (addr < 0x000100000000ULL) ||
----------------
` (__riscv_xlen == 64) ->  __riscv_xlen == 64`


================
Comment at: compiler-rt/test/msan/mmap.cpp:69
   const size_t kMapSize = 0x100000000ULL;
+#elif defined(__riscv) && (__riscv_xlen == 64)
+  const size_t kMapSize = 0x80000000ULL;
----------------
ditto


================
Comment at: compiler-rt/test/msan/mmap_below_shadow.cpp:36
   const uintptr_t app_start = 0x7000000000ULL;
+#elif defined(__riscv) && (__riscv_xlen == 64)
+  uintptr_t hint = 0x000a00000000ULL;
----------------
ditto


================
Comment at: compiler-rt/test/msan/param_tls_limit.cpp:23
+// parameters passes but is extremely verbose.
+// XFAIL: riscv64
 
----------------
If you expect riscv32 will fail as well, use `riscv`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97897/new/

https://reviews.llvm.org/D97897