[PATCH] D99388: [AArch64][GlobalISel] Combine funnel shifts to rotates.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 10:27:39 PDT 2021


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

Looks fine to me, thanks.



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3893
+                                         : TargetOpcode::G_ROTR));
+  MI.RemoveOperand(1);
+  Observer.changedInstr(MI);
----------------
`(2)` would be infinitesimally more efficient! :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99388/new/

https://reviews.llvm.org/D99388



More information about the llvm-commits mailing list