[PATCH] D74588: Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests

Tue Mar 30 09:43:23 PDT 2021

aaronpuchert added a comment.

In D74588#2658871 <https://reviews.llvm.org/D74588#2658871>, @beanz wrote:

> Yep, and that's because of a different bug in how LLVMTableGenGlobalISel was setup.
>
> This patch would address the issues: [...]

Ok, that allows me to remove the `DISABLE_LLVM_LINK_LLVM_DYLIB`, but

- maybe it would be confusing to have an LLVM component in `llvm/utils` instead of `llvm/lib`, and
- maybe this shouldn't be part of LLVM because it's only needed for `llvm-tblgen`? In other words maybe this isn't actually a component of LLVM proper but just a tool for building LLVM. If we make it a component library it will be part of `libLLVM.so`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74588/new/

https://reviews.llvm.org/D74588