[PATCH] D97667: [loop-idiom] Hoist loop memcpys to loop preheader

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 09:37:30 PDT 2021


lebedev.ri added a comment.

In D97667#2658951 <https://reviews.llvm.org/D97667#2658951>, @hoy wrote:

> In D97667#2657994 <https://reviews.llvm.org/D97667#2657994>, @lebedev.ri wrote:
>
>> Is @zino someone's replacement account?
>> I'm asking because the accept of this revision is the only contribution of that account.
>
> Zino is a real LLVM developer. @zino  looks like your email is not verified.

Not as per https://reviews.llvm.org/people/commits/21223/ / https://reviews.llvm.org/people/revisions/21223/, which is why i asked.
Docs aren't quite clear on this, but the subtext is that reviews only count
if the reviewee is actually familiar with the code (and that can be seen from `git log`),
and is an [upstream!] llvm dev.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97667/new/

https://reviews.llvm.org/D97667



More information about the llvm-commits mailing list