[PATCH] D98884: [IR] Ignore bitcasts of function pointers which are only used as callees in callbase instruction

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 09:32:10 PDT 2021


rampitec accepted this revision.
rampitec added a comment.

LGTM with a nit in 2 tests. Please also wait for other responses.



================
Comment at: llvm/test/Transforms/GlobalOpt/bitcast-call-argument-fastcc.ll:10
+; CHECK-NOT: define internal fastcc i32 @foo() {
+define internal i32 @foo() {
+entry:
----------------
Make a positive check for foo.


================
Comment at: llvm/test/Transforms/GlobalOpt/bitcast-call-argument-fastcc.ll:21
+; CHECK-NOT: define fastcc i32 @test()
+define i32 @test() {
+  ; CHECK: call fastcc i32 @bar(float ()* bitcast (i32 ()* @foo to float ()*))
----------------
Also need positive check for test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98884/new/

https://reviews.llvm.org/D98884



More information about the llvm-commits mailing list