[PATCH] D99518: [flang][driver] Modify the existing test cases that use -Mstandard in f18, to use -pedantic and %flang_fc1 to share with the new driver
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 30 09:27:43 PDT 2021
awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.
Thank you for working on this! I would be tempted to make this patch depend on https://reviews.llvm.org/D98657. It's up to you.
[nit] I think that it's worth shortening the commit summary (i.e. the first line). Perhaps this: `[flang][driver] Port tests to use `-pedantic` instead of `-Mstandard`. Shorter messages do make `git log` easier to navigate. You could move the contents of your top line to the summary.
As the above are nits, accepting as is!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99518/new/
https://reviews.llvm.org/D99518
More information about the llvm-commits
mailing list