[PATCH] D97667: [loop-idiom] Hoist loop memcpys to loop preheader

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D97667#2657994 <https://reviews.llvm.org/D97667#2657994>, @lebedev.ri wrote:

> Is @zino someone's replacement account?
> I'm asking because the accept of this revision is the only contribution of that account.

Zino is a real LLVM developer. @zino  looks like your email is not verified.



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:818
+        I = BB->begin();
+      continue;
+    }
----------------
No need of this `continue`?


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1211
+  bool IsMemCpy = isa<MemCpyInst>(TheStore);
+  const std::string InstRemark = IsMemCpy ? "memcpy" : "load and store";
+
----------------
Nit: Use 'StringRef` to avoid extra mem allocation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97667/new/

https://reviews.llvm.org/D97667