[PATCH] D99351: [CSSPGO] Top-down processing order based on full profile.

[Wenlei He via Phabricator via llvm-commits]

wenlei accepted this revision.
wenlei added a comment.
This revision is now accepted and ready to land.

lgtm, thanks.



================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:1605
+  if (!ProfileTopDownLoad && UseProfiledCallGraph)
+    errs() << "WARNING: -use-profiled-call-graph ignored, should be used "
+              "together with -sample-profile-top-down-load.\n";
----------------
hoy wrote:
> wenlei wrote:
> > Is this the canonical way of emit warning? Or something through diagnostics like `LLVMContext.diagnose(DiagnosticInfoSampleProfile(..., DS_Warning))`?
> The usage of `errs()` to display text messages is quite common, I also used that in lld, though it is not a formal way to emit warnings that users can track in documents.
Yeah, saw inconsistent messages all over the place.. "WARNING", "warning" and "Warning". I guess we're not making it worse. :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99351/new/

https://reviews.llvm.org/D99351