[PATCH] D99575: [ARM] Clarify a comment regarding AArch64. NFC.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp:32
     : MCWinCOFFObjectTargetWriter(COFF::IMAGE_FILE_MACHINE_ARMNT) {
-    assert(!Is64Bit && "AArch64 support not yet implemented");
+    assert(!Is64Bit && "AArch64 is an entirely different target");
   }
----------------
compnerd wrote:
> ARM64 is a different target, but the COFF writer can be shared across the two right?  What makes it special?  A comment to that effect would be useful.  I think that we might want to try to push this upwards to avoid the parameter all together if the two paths cannot be merged.
You mean this class? Almost everything in each of them is different between the two, so I don't really see what benefits there would be to stuffing both into one class with conditionals around everything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99575/new/

https://reviews.llvm.org/D99575