[PATCH] D93503: [GVN] Propagate llvm.access.group metadata of loads

Tue Mar 30 07:46:21 PDT 2021

fhahn accepted this revision.
fhahn added a comment.

In D93503#2500308 <https://reviews.llvm.org/D93503#2500308>, @kawashima-fj wrote:

> I'm sorry for the late response. I (and my colleague) updated the test.
>
> In D93503#2484226 <https://reviews.llvm.org/D93503#2484226>, @fhahn wrote:
>
>> Thanks for cleaning up the test. It left a few additional small suggestions. I think for that test it would be good to add CHECK lines for all code generated during PRE. Given it is quite small, you could use `llvm/utils/update_test_checks.py` to auto-generate the check lines. Also, I think it would be good to pre-commit the test with check lines for current trunk and then update the patch to just show the diff in CHECK lines with this patch.
>
> You mean I should push two commits to the GitHub repository, right?
> The first one is only the test file with CHECK-lines generated by `update_test_checks.py` with current `master` branch.
> The second one is update of the GVN source file and CHECK-lines generated by `update_test_checks.py` with the new source code.

Yep that would be the idea. You can just push the update to the existing test and then update the review.

The change LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93503/new/

https://reviews.llvm.org/D93503