[PATCH] D99055: [llvm-objcopy] Refactor CopyConfig structure.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

> I do have some concerns about the multiple inheritance stuff going on, if I'm honest, as usually this is a design smell

The idea here is to reuse only data. The most weaknesses of multiplue inheritance in C++ 
came with handling of inherited methods. virtual inheritance of data members looks
safe(since they could not be redefined). Though, copy and move operators should be properly addressed.
But if there is something bad with this approach I am open to change it.

> I do still think you should normalise the error messages in a separate prerequisite change. Small changes are good, especially if it helps make something else a pure refactor.

will create a separate review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99055/new/

https://reviews.llvm.org/D99055