[PATCH] D99544: [VPlan] Use SmallVector for VPExternalDefs to prevent non-determinism.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 07:06:42 PDT 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1770
   // (operators '==' and '<').
-  SmallPtrSet<VPValue *, 16> VPExternalDefs;
+  SmallVector<VPValue *, 16> VPExternalDefs;
 
----------------
Should this be `SetVector`?  I think we still want to avoid adding duplicates.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99544/new/

https://reviews.llvm.org/D99544



More information about the llvm-commits mailing list