[llvm] 80fb743 - [test, HardwareLoops] Fix use of var defined in CHECK-NOT

Thomas Preud'homme via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 07:06:30 PDT 2021


Author: Thomas Preud'homme
Date: 2021-03-30T15:06:32+01:00
New Revision: 80fb7434e9e7bea65a49d2234092b48419e5dc52

URL: https://github.com/llvm/llvm-project/commit/80fb7434e9e7bea65a49d2234092b48419e5dc52
DIFF: https://github.com/llvm/llvm-project/commit/80fb7434e9e7bea65a49d2234092b48419e5dc52.diff

LOG: [test, HardwareLoops] Fix use of var defined in CHECK-NOT

LLVM test Transforms/HardwareLoops/ARM/structure.ll tries to check for
the absence of a sequence of instructions with several CHECK-NOT with
one of those directives using a variable defined in another. However
CHECK-NOT are checked independently so that is using a variable defined
in a pattern that should not occur in the input.

This commit only checks for the absence of llvm.loop.decrement.i32 which
rules out the presence of the whole sequence and does not involve an
undefined variable.

Reviewed By: dmgreen

Differential Revision: https://reviews.llvm.org/D99591

Added: 
    

Modified: 
    llvm/test/Transforms/HardwareLoops/ARM/structure.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/HardwareLoops/ARM/structure.ll b/llvm/test/Transforms/HardwareLoops/ARM/structure.ll
index c611bc217796..236cc30eadde 100644
--- a/llvm/test/Transforms/HardwareLoops/ARM/structure.ll
+++ b/llvm/test/Transforms/HardwareLoops/ARM/structure.ll
@@ -60,8 +60,7 @@ do.end:
 ; CHECK: [[CMP:%[^ ]+]] = icmp ne i32 [[LOOP_DEC]], 0
 ; CHECK: br i1 [[CMP]], label %while.body3.us, label %while.cond1.while.end_crit_edge.us
 
-; CHECK-NOT: [[LOOP_DEC1:%[^ ]+]] = call i1 @llvm.loop.decrement.i32(i32 1)
-; CHECK-NOT: br i1 [[LOOP_DEC1]], label %while.cond1.preheader.us, label %while.end7
+; CHECK-NOT: %{{[^ ]+}} = call i1 @llvm.loop.decrement.i32(i32 1)
 
 define void @nested(i32* nocapture %A, i32 %N) {
 entry:


        


More information about the llvm-commits mailing list