[PATCH] D98169: [PoC][IR] Permit load/store/alloca for struct with the same scalable vectors.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 29 19:29:08 PDT 2021
craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/Analysis.cpp:92
// need offsets.
const StructLayout *SL = Offsets ? DL.getStructLayout(STy) : nullptr;
for (StructType::element_iterator EB = STy->element_begin(),
----------------
craig.topper wrote:
> Can we remove the conditional here and always get the the struct layout? Then we don't need to check for null StructLayout in the loop. This was one of the change we did previously when we allowed scalable vectors in structs for intrinsic returns.
Nevermind. We need this to support a mix of scalable and scalars for intrinsic returns.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98169/new/
https://reviews.llvm.org/D98169
More information about the llvm-commits
mailing list