[PATCH] D99587: [AMDGPU] Deduce sign from address space

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 06:43:30 PDT 2021


sebastian-ne added a comment.

We already use this connection in `SIInstrInfo::isLegalFLATOffset`, there is a check for `ST.hasFlatSegmentOffsetBug() && AddrSpace == AMDGPUAS::FLAT_ADDRESS`. I guess this is already broken then.

Is there a good way to find the instruction variant (global, scratch or flat) from the instruction (or intrinsic) or do we need to pass this through everywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99587/new/

https://reviews.llvm.org/D99587



More information about the llvm-commits mailing list