[PATCH] D99587: [AMDGPU] Deduce sign from address space

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 06:14:30 PDT 2021


sebastian-ne created this revision.
sebastian-ne added reviewers: arsenm, rampitec.
Herald added subscribers: kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
sebastian-ne requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

The immediate offset of flat instructions is signed for the global_
and scratch_ variants and unsigned for the flat_ variant.
We can deduce the signdness of the offset automatically from the address
space instead of passing it through everywhere.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99587

Files:
  llvm/lib/Target/AMDGPU/AMDGPUGISel.td
  llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/lib/Target/AMDGPU/FLATInstructions.td
  llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
  llvm/lib/Target/AMDGPU/SIInstrInfo.h
  llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99587.334134.patch
Type: text/x-patch
Size: 18580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210330/ad9fa2f8/attachment.bin>


More information about the llvm-commits mailing list