[PATCH] D99582: [test, LoopVectorize] Fix use of var defined in CHECK-NOT

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre created this revision.
thopre added reviewers: dorit, silviu.baranga, Ayal, hfinkel.
thopre requested review of this revision.
Herald added a project: LLVM.

LLVM test Transforms/LoopVectorize/pr34681.ll tries to check for the
absence of a sequence of instructions with several CHECK-NOT with one of
those directives using a variable defined in another. However CHECK-NOT
are checked independently so that is using a variable defined in a
pattern that should not occur in the input.

This commit only checks for the absence of icmp ne 1 which rules out the
presence of the whole sequence and does not involve an undefined
variable.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99582

Files:
  llvm/test/Transforms/LoopVectorize/pr34681.ll


Index: llvm/test/Transforms/LoopVectorize/pr34681.ll
===================================================================
--- llvm/test/Transforms/LoopVectorize/pr34681.ll
+++ llvm/test/Transforms/LoopVectorize/pr34681.ll
@@ -22,9 +22,7 @@
 
 ; CHECK-LABEL: @foo1
 ; CHECK: for.body.lr.ph
-; CHECK-NOT: %ident.check = icmp ne i32 %N, 1
-; CHECK-NOT: %[[TEST:[0-9]+]] = or i1 false, %ident.check
-; CHECK-NOT: br i1 %[[TEST]], label %scalar.ph, label %vector.ph
+; CHECK-NOT: %ident.check = icmp ne i32 %N, 1{{(.*[[:space:]])+}} %[[TEST:[0-9]+]] = or i1 false, %ident.check{{(.*[[:space:]])+}} br i1 %[[TEST]], label %scalar.ph, label %vector.ph
 ; CHECK: vector.ph
 ; CHECK: vector.body
 ; CHECK: <4 x i32>
@@ -82,8 +80,6 @@
 ; CHECK-LABEL: @foo2
 ; CHECK: for.body.lr.ph
 ; CHECK-NOT: %ident.check = icmp ne i16 %N, 1
-; CHECK-NOT: %[[TEST:[0-9]+]] = or i1 false, %ident.check
-; CHECK-NOT: br i1 %[[TEST]], label %scalar.ph, label %vector.ph
 ; CHECK: vector.ph
 ; CHECK: vector.body
 ; CHECK: <4 x i32>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99582.334123.patch
Type: text/x-patch
Size: 1005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210330/fcff5e8a/attachment.bin>