[PATCH] D99352: [AMDGPU] ds_read_*/ds_write_* operations require strict alignment.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 03:57:47 PDT 2021


foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/ds_read2.ll:603
+; GFX9-UNALIGNED-NEXT:  v_add_u32_e32 v1, s4, v0
+; GFX9-UNALIGNED-NEXT:  ds_read_u8 v2, v1
+; GFX9-UNALIGNED-NEXT:  ds_read_u8 v3, v1 offset:1
----------------
@rampitec didn't you say that you rely on unaligned dword reads to get good performance? So I guess this change is unacceptable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99352/new/

https://reviews.llvm.org/D99352



More information about the llvm-commits mailing list